Skip to content

Conversation

@Zentrik
Copy link
Owner

@Zentrik Zentrik commented Apr 20, 2025

Seemed like it would work locally and maybe gives some speedup with libgit2

Seemed like it would work locally and maybe gives some speedup with libgit2
fi
cd L/LLVM/LLVM_full@20
rm -rf bundled/libcxx_patches
Copy link
Owner Author

@Zentrik Zentrik Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat confused how musl is building currently

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might just be applying a patch to the headers that the resultant libcxx will ship, so wouldn't cause a build failure (given we don't try building julia with musl).

@Zentrik
Copy link
Owner Author

Zentrik commented Apr 20, 2025

Hmm checkout seemed to take 42s on 1.7 and 1.12, maybe the speedup might be more significant if llvm repo wasn't cached? Still, seems like libgit2 slowness might not have been fixed.

@Zentrik
Copy link
Owner Author

Zentrik commented Sep 2, 2025

Alternative fix to libgit2 slowness is just replacing the GitSource with smth like DirectorySource("/home/rag/Documents/Code/llvm-project", target="llvm-project") and cloning manually. But anyways unlikely to get much of a speedup here if it only takes 42s.

@giordano
Copy link

giordano commented Sep 2, 2025

Yeah, ~45s isn't too bad.

BINARYBUILDER_CCACHE_DIR: ${{ github.workspace }}/binarybuilder_ccache
LLVM_VERSION: ${{ inputs.LLVM_VERSION }}
LLVM_VERSION_MAJOR: ${{ inputs.LLVM_VERSION_MAJOR }}
JULIA_REGISTRYCI_AUTOMERGE: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wondered if anyone would notice this trick for using BB in other Julia versions 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants